Skip to content

Enable environment variables for attribute filters #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 3, 2025
Merged

Enable environment variables for attribute filters #1558

merged 11 commits into from
Nov 3, 2025
+56 −22

Conversation

@lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Oct 28, 2025 •
edited
Loading

This PR adds the option to use environment variables to enable/disable attributes as well as exclude/include filtering rules.

This can be useful for users running New Relic without an *.ini file.

The following have been added:

NEW_RELIC_ATTRIBUTES_ENABLED
NEW_RELIC_ATTRIBUTES_EXCLUDE
NEW_RELIC_ATTRIBUTES_INCLUDE
NEW_RELIC_BROWSER_MONITORING_ATTRIBUTES_ENABLED
NEW_RELIC_BROWSER_MONITORING_ATTRIBUTES_EXCLUDE
NEW_RELIC_BROWSER_MONITORING_ATTRIBUTES_INCLUDE
NEW_RELIC_ERROR_COLLECTOR_ATTRIBUTES_ENABLED
NEW_RELIC_ERROR_COLLECTOR_ATTRIBUTES_EXCLUDE
NEW_RELIC_ERROR_COLLECTOR_ATTRIBUTES_INCLUDE
NEW_RELIC_SPAN_EVENTS_ATTRIBUTES_ENABLED
NEW_RELIC_SPAN_EVENTS_ATTRIBUTES_EXCLUDE
NEW_RELIC_SPAN_EVENTS_ATTRIBUTES_INCLUDE
NEW_RELIC_TRANSACTION_EVENTS_ATTRIBUTES_ENABLED
NEW_RELIC_TRANSACTION_EVENTS_ATTRIBUTES_EXCLUDE
NEW_RELIC_TRANSACTION_EVENTS_ATTRIBUTES_INCLUDE
NEW_RELIC_TRANSACTION_SEGMENTS_ATTRIBUTES_ENABLED
NEW_RELIC_TRANSACTION_SEGMENTS_ATTRIBUTES_EXCLUDE
NEW_RELIC_TRANSACTION_SEGMENTS_ATTRIBUTES_INCLUDE
NEW_RELIC_TRANSACTION_TRACER_ATTRIBUTES_ENABLED
NEW_RELIC_TRANSACTION_TRACER_ATTRIBUTES_EXCLUDE
NEW_RELIC_TRANSACTION_TRACER_ATTRIBUTES_INCLUDE

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.92s
✅ MARKDOWN markdownlint 7 0 0 0 1.37s
✅ PYTHON ruff 948 0 0 0 1.02s
✅ PYTHON ruff-format 948 0 0 0 0.31s
✅ YAML prettier 15 0 0 0 1.41s
✅ YAML v8r 15 0 0 6.07s
✅ YAML yamllint 15 0 0 0.72s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@lrafeei lrafeei marked this pull request as ready for review October 28, 2025 19:10
@lrafeei lrafeei requested a review from a team as a code owner October 28, 2025 19:10
@mergify mergify bot added the tests-failing Tests failing in CI. label Oct 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.78%. Comparing base (8577eb7) to head (7c371b8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1558   +/-   ##
=======================================
  Coverage   81.77%   81.78%           
=======================================
  Files         207      207           
  Lines       23953    23953           
  Branches     3799     3799           
=======================================
+ Hits        19588    19589    +1     
  Misses       3098     3098           
+ Partials     1267     1266    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot removed the tests-failing Tests failing in CI. label Oct 28, 2025
TimPansino
TimPansino requested changes Oct 28, 2025
View reviewed changes
@mergify mergify bot added the tests-failing Tests failing in CI. label Oct 29, 2025
@lrafeei lrafeei requested a review from TimPansino October 29, 2025 23:10
@TimPansino TimPansino enabled auto-merge (squash) November 3, 2025 21:07
@lrafeei lrafeei added this to the v11.1.0 milestone Nov 3, 2025
@TimPansino TimPansino modified the milestone: v11.1.0 Nov 3, 2025
@Newrelic-Boomi
Copy link

Newrelic-Boomi commented Nov 3, 2025

https://new-relic.atlassian.net/browse/NR-484169

@TimPansino TimPansino merged commit 8c91a74 into main Nov 3, 2025
106 of 108 checks passed
@TimPansino TimPansino deleted the add-attributes-env-vars branch November 3, 2025 22:53
@mergify mergify bot removed the tests-failing Tests failing in CI. label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimPansino TimPansino TimPansino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v11.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lrafeei @codecov-commenter @Newrelic-Boomi @TimPansino